[Yanel-commits] rev 45775 - public/yanel/trunk/src/webapp/src/java/org/wyona/yanel/servlet/menu

[michi at wyona.com]

Author: michi
Date: 2009-12-01 14:53:55 +0100 (Tue, 01 Dec 2009)
New Revision: 45775

Modified:
   public/yanel/trunk/src/webapp/src/java/org/wyona/yanel/servlet/menu/RevisionTransitions.java
Log:
refactored

Modified: public/yanel/trunk/src/webapp/src/java/org/wyona/yanel/servlet/menu/RevisionTransitions.java
===================================================================
--- public/yanel/trunk/src/webapp/src/java/org/wyona/yanel/servlet/menu/RevisionTransitions.java	2009-12-01 13:53:12 UTC (rev 45774)
+++ public/yanel/trunk/src/webapp/src/java/org/wyona/yanel/servlet/menu/RevisionTransitions.java	2009-12-01 13:53:55 UTC (rev 45775)
@@ -44,33 +44,31 @@
         this.menuItems = menuItems;
     }
 
-    private String getContent() {
-        String content = "";
+    /**
+     * @see org.wyona.yanel.servlet.menu.RevisionTransitionsMenuContent#toHTML()
+     */
+    public String toHTML() {
+        StringBuilder html = new StringBuilder("");
 
         try {
             Workflow workflow = WorkflowHelper.getWorkflow(this.resource);
             
             if (workflow != null) {
-                content = "<ul>";
+                html.append("<ul>");
 
-//                WorkflowableV1 workflowable = (WorkflowableV1) this.resource;
-//                String state = workflowable.getWorkflowState(revision);
-
                 Transition[] transitions = workflow.getTransitions();
-
                 for (int i = 0; i < transitions.length; i++) {
-                    content += menuItems.getTransitionElement(transitions[i]);
+                    html.append(menuItems.getTransitionElement(transitions[i]));
                 }
 
-                content += "</ul>";
+                html.append("</ul>");
             }
-            
         } catch (WorkflowException e) {
-            content = "";
+            html.append("<ul><li>Exception: " + e.getMessage() + "</li></ul>");
             log.error("Could not get workflow.", e);
         }
 
-        return content;
+        return html.toString();
     }
 
     /* (non-Javadoc)
@@ -86,12 +84,4 @@
     public Resource getResource() {
         return this.resource;
     }
-
-    /* (non-Javadoc)
-     * @see org.wyona.yanel.servlet.menu.RevisionTransitionsMenuContent#toHTML()
-     */
-    public String toHTML() {
-        return getContent();
-    }
-
 }