[Yanel-dev] Re: [Yanel-commits] rev
40223 - public/yanel/trunk/src/core/java/org/wyona/yanel/core/workflow
Michael Wechner
michael.wechner at wyona.com
Tue Dec 2 17:05:01 CET 2008
Guillaume Déflache schrieb:
>> Modified:
>> public/yanel/trunk/src/core/java/org/wyona/yanel/core/workflow/WorkflowBuilder.java
>>
>> ===================================================================
>> ---
>> public/yanel/trunk/src/core/java/org/wyona/yanel/core/workflow/WorkflowBuilder.java
>> 2008-12-02 12:48:32 UTC (rev 40222)
>> +++
>> public/yanel/trunk/src/core/java/org/wyona/yanel/core/workflow/WorkflowBuilder.java
>> 2008-12-02 12:48:46 UTC (rev 40223)
> [...]
>> + /**
>> + * Create DOM from input stream
>> + */
>> private Document readDocument(InputStream stream) throws
>> Exception {
>> + return org.wyona.commons.xml.XMLHelper.readDocument(stream);
>> +/*
>> DocumentBuilder builder = createBuilder();
>> return builder.parse(stream);
>> +*/
> [...]
>> + return org.wyona.commons.xml.XMLHelper.createBuilder();
>> +/*
>> DocumentBuilderFactory factory =
>> DocumentBuilderFactory.newInstance();
>> factory.setNamespaceAware(true);
>> DocumentBuilder builder = factory.newDocumentBuilder();
>> @@ -60,6 +67,7 @@
>> CatalogResolver cr = new CatalogResolver();
>> builder.setEntityResolver(cr);
>> return builder;
>> +*/
>
> Why not getting dead code out of our way?!?
at the time I have refactored this I wasn't sure if it would really work
and I wanted to make sure that we can switch back very easily
without having to dig within SVN. At the same time I wanted to write
tests, but it wasn't that easy and got stuck.
But, yes, you are very right. Let me make a comment for the moment and I
will try to continue on the test.
Cheers
Michi
> _______________________________________________
> Yanel-development mailing list
> Yanel-development at wyona.com
> http://lists.wyona.org/cgi-bin/mailman/listinfo/yanel-development
More information about the Yanel-development
mailing list